[jira] [Commented] (YARN-6133) [ATSv2 Security] Renew delegation token for app automatically if an app collector is active

[Jian He (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119168#comment-16119168
 ] 

Jian He commented on YARN-6133:
-------------------------------

lgtm overall,  minor comments:
- log the new expiration time also ? in case for debugging 
{code}
LOG.info("Renewed token for " + appId);
{code}
- in test case, can you add a comment why this is needed
{code}
    if (!withKerberosLogin) {
      conf.setLong(
          YarnConfiguration.TIMELINE_DELEGATION_TOKEN_RENEW_INTERVAL, 100);
    }
{code}
- add if(tokenRenewalExecutor !=null) ? 
{code}
    tokenRenewalExecutor.shutdownNow();
{code}

> [ATSv2 Security] Renew delegation token for app automatically if an app 
> collector is active
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-6133
>                 URL: https://issues.apache.org/jira/browse/YARN-6133
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-5355-merge-blocker
>         Attachments: YARN-6133-YARN-5355.01.patch, 
> YARN-6133-YARN-5355.02.patch, YARN-6133-YARN-5355.03.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org