[
https://issues.apache.org/jira/browse/YARN-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124354#comment-16124354
]
Karthik Kambatla commented on YARN-6964:
----------------------------------------
Thanks for looking into these, Daniel. Comments on the patch:
# # AllocationConfiguration: the change changes behavior. If minQueueResource
is not greater than the default, the new code returns component-wise-max while
the old code returned minQueueResource
# FSLeafQueue:
## Resources.min is not the same as componentWiseMin. And, the calculator is
important to know which resources to consider first.
## Change from Resources.isNone to isNonZero also doesn't seem right.
# FairSharePolicy: Couple of instances of "Resources.min is not the same as
componentWiseMin"
# If we are not changing the behavior, why do we need the change to
TestFileAllocationLoaderService?
> Fair scheduler misuses Resources operations
> -------------------------------------------
>
> Key: YARN-6964
> URL: https://issues.apache.org/jira/browse/YARN-6964
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 3.0.0-alpha4
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: YARN-6964.001.patch, YARN-6964.002.patch,
> YARN-6964.003.patch, YARN-6964.004.patch, YARN-6964.005.patch
>
>
> There are several places where YARN uses the {{Resources}} class to do
> comparisons of {{Resource}} instances incorrectly. This patch corrects those
> mistakes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
