[
https://issues.apache.org/jira/browse/YARN-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133295#comment-16133295
]
Arun Suresh edited comment on YARN-6923 at 8/18/17 5:13 PM:
------------------------------------------------------------
Thanks for verifying [~giovanni.fumarola]. Was just looking closely again.
In {{submitApplication}} method for eg,
we have a loop for number of retries, and you do
{{routerMetrics.incrAppsFailedSubmitted()}} everytime it fails in the loop.
Shouldn't that metric be incremented only if submit has failed for ALL the
retires ?
I see the same pattern in all the calls. If that is the expected behavior, I am
fine with it, but just confirm if that is in fact the expected behavior.
was (Author: asuresh):
Thanks for verifying GIo. Was just looking closely again.
In {{submitApplication}} method for eg,
we have a loop for number of retries, and you do
{{routerMetrics.incrAppsFailedSubmitted()}} everytime it fails in the loop.
Shouldn't that metric be incremented only if submit has failed for ALL the
retires ?
I see the same pattern in all the calls. If that is the expected behavior, I am
fine with it, but just confirm if that is in fact the expected behavior.
> Metrics for Federation Router
> -----------------------------
>
> Key: YARN-6923
> URL: https://issues.apache.org/jira/browse/YARN-6923
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Giovanni Matteo Fumarola
> Assignee: Giovanni Matteo Fumarola
> Attachments: YARN-6923.v1.patch, YARN-6923.v2.patch
>
>
> This JIRA proposes addition of metrics for Federation StateStore
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
