[ 
https://issues.apache.org/jira/browse/YARN-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137133#comment-16137133
 ] 

ASF GitHub Bot commented on YARN-2162:
--------------------------------------

Github user flyrain commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/261#discussion_r134560857
  
    --- Diff: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestAllocationFileLoaderService.java
 ---
    @@ -235,21 +235,21 @@ public void testAllocationFileParsing() throws 
Exception {
             queueConf.getMinResources("root." + 
YarnConfiguration.DEFAULT_QUEUE_NAME));
     
         assertEquals(Resources.createResource(2048, 10),
    -        queueConf.getMaxResources("root.queueA"));
    +        queueConf.getMaxResources("root.queueA").getResource());
         assertEquals(Resources.createResource(5120, 110),
    -        queueConf.getMaxResources("root.queueB"));
    -    assertEquals(Resources.createResource(5120, 0),
    -        queueConf.getMaxResources("root.queueC"));
    +        queueConf.getMaxResources("root.queueB").getResource());
    +    assertEquals(Resources.createResource(4096, 100),
    --- End diff --
    
    The logic to set max share to min share if max share is less than min share 
has been moved to FSQueue#getMaxShare


> add ability in Fair Scheduler to optionally configure maxResources in terms 
> of percentage
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-2162
>                 URL: https://issues.apache.org/jira/browse/YARN-2162
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler, scheduler
>            Reporter: Ashwin Shankar
>            Assignee: Yufei Gu
>              Labels: scheduler
>         Attachments: YARN-2162.001.patch, YARN-2162.002.patch
>
>
> minResources and maxResources in fair scheduler configs are expressed in 
> terms of absolute numbers X mb, Y vcores. 
> As a result, when we expand or shrink our hadoop cluster, we need to 
> recalculate and change minResources/maxResources accordingly, which is pretty 
> inconvenient.
> We can circumvent this problem if we can optionally configure these 
> properties in terms of percentage of cluster capacity. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to