[ 
https://issues.apache.org/jira/browse/YARN-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137546#comment-16137546
 ] 

Subru Krishnan commented on YARN-7053:
--------------------------------------

Thanks [~jhung] for updating the patch. Let's look at how the tests go for v4.

We do *not* need fencing in {{ZookeeperFederationStateStore}} as we rely on RM 
for that. That's why after looking at the code I wanted to skip this. So you'll 
have to revert the changes to {{ZookeeperFederationStateStore}} (sorry).

In {{TestZKCuratorManager::testTransaction}}, this should be false after 
deletion right?
{quote} assertTrue(Arrays.equals(setData, curator.getData(node1)));{quote}



> Move curator transaction support to ZKCuratorManager
> ----------------------------------------------------
>
>                 Key: YARN-7053
>                 URL: https://issues.apache.org/jira/browse/YARN-7053
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Jonathan Hung
>            Assignee: Jonathan Hung
>         Attachments: YARN-7053.001.patch, YARN-7053.002.patch, 
> YARN-7053.003.patch, YARN-7053.004.patch
>
>
> HADOOP-14741 moves curator functionality to ZKCuratorManager. ZKRMStateStore 
> has some curator transaction support which can be reused, so this can be 
> moved to ZKCuratorManager as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to