[ https://issues.apache.org/jira/browse/YARN-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725211#comment-13725211 ]
Hudson commented on YARN-966: ----------------------------- FAILURE: Integrated in Hadoop-Hdfs-trunk #1477 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1477/]) YARN-966. Fixed ContainerLaunch to not fail quietly when there are no localized resources due to some other failure. Contributed by Zhijie Shen. (vinodkv: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1508688) * /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/TestContainer.java * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainerLaunch.java > The thread of ContainerLaunch#call will fail without any signal if > getLocalizedResources() is called when the container is not at LOCALIZED > ------------------------------------------------------------------------------------------------------------------------------------------- > > Key: YARN-966 > URL: https://issues.apache.org/jira/browse/YARN-966 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Zhijie Shen > Assignee: Zhijie Shen > Fix For: 2.1.1-beta > > Attachments: YARN-966.1.patch > > > In ContainerImpl.getLocalizedResources(), there's: > {code} > assert ContainerState.LOCALIZED == getContainerState(); // TODO: FIXME!! > {code} > ContainerImpl.getLocalizedResources() is called in ContainerLaunch.call(), > which is scheduled on a separate thread. If the container is not at LOCALIZED > (e.g. it is at KILLING, see YARN-906), an AssertError will be thrown and > fails the thread without notifying NM. Therefore, the container cannot > receive more events, which are supposed to be sent from > ContainerLaunch.call(), and move towards completion. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira