[
https://issues.apache.org/jira/browse/YARN-6876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145895#comment-16145895
]
Xuan Gong commented on YARN-6876:
---------------------------------
[~jlowe]
bq. Sorry for the late comment, but I was just looking at the code in trunk and
saw a bunch of close calls changed to quiet forms. Seems to me this could
silently swallow errors encountered during close which would be a bad thing. I
saw that this was brought up earlier in the review but I didn't see it
addressed in the comments.
Previously, we always use IOUtils.cleanup (this is deprecated ) and
IOUtils.closeStream(this will swallow the errors as well). If we want to catch
the errors, we might need to use cleanupWithLogger. If this is fine, I can
create a jira and address this issue separately.
> Create an abstract log writer for extendability
> -----------------------------------------------
>
> Key: YARN-6876
> URL: https://issues.apache.org/jira/browse/YARN-6876
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Fix For: 2.9.0, 3.0.0-beta1
>
> Attachments: YARN-6876-branch-2.001.patch, YARN-6876-trunk.001.patch,
> YARN-6876-trunk.002.patch, YARN-6876-trunk.003.patch,
> YARN-6876-trunk.004.patch, YARN-6876-trunk.005.patch,
> YARN-6876-trunk.006.patch
>
>
> Currently, TFile log writer is used to aggregate log in YARN. We need to add
> an abstract layer, and pick up the correct log writer based on the
> configuration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
