[ 
https://issues.apache.org/jira/browse/YARN-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated YARN-906:
-----------------------------

    Attachment: YARN-906.5.patch

Thanks Vinod for the suggestions. Uploaded the new patch.

bq. When a container is killed before launching, the TERMINATED exit code seems 
fine, but the message can be something like "Container terminated before 
launch."

Changed the message, but by tracing the code, it seems that the message in the 
event will never be used in the killing transition, and "Killed by external 
signal" will always be added to the diagnostics. Anyway, I think it should be 
fine.

In addition, a test case is added for killing the container before it is 
launched.
                
> Cancelling ContainerLaunch#call at KILLING causes that the container cannot 
> be completed
> ----------------------------------------------------------------------------------------
>
>                 Key: YARN-906
>                 URL: https://issues.apache.org/jira/browse/YARN-906
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-906.1.patch, YARN-906.2.patch, YARN-906.3.patch, 
> YARN-906.4.patch, YARN-906.5.patch
>
>
> See 
> https://builds.apache.org/job/PreCommit-YARN-Build/1435//testReport/org.apache.hadoop.yarn.client.api.impl/TestNMClient/testNMClientNoCleanupOnStop/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to