[
https://issues.apache.org/jira/browse/YARN-6877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149560#comment-16149560
]
Junping Du commented on YARN-6877:
----------------------------------
Thanks [~xgong] for updating the patch. 007 patch looks good in overall. Only
one small NIT here:
In LogCLIHelpers.dumpAContainerLogsForLogTypeWithoutNodeId() we still catch
IOException instead of throw it out.
Will +1 after fixing this.
> Create an abstract log reader for extendability
> -----------------------------------------------
>
> Key: YARN-6877
> URL: https://issues.apache.org/jira/browse/YARN-6877
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-6877-branch-2.001.patch, YARN-6877-trunk.001.patch,
> YARN-6877-trunk.002.patch, YARN-6877-trunk.003.patch,
> YARN-6877-trunk.004.patch, YARN-6877-trunk.005.patch,
> YARN-6877-trunk.006.patch, YARN-6877-trunk.007.patch
>
>
> Currently, TFile log reader is used to read aggregated log in YARN. We need
> to add an abstract layer, and pick up the correct log reader based on the
> configuration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
