[ 
https://issues.apache.org/jira/browse/YARN-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159595#comment-16159595
 ] 

Daniel Templeton commented on YARN-7146:
----------------------------------------

Looks generally good.  The comment on {{update()}} still leaves a bit much to 
the imagination.  You can't make it too FS specific, but at least give it some 
context.  When should it be called and how often with what general intended 
effect?  Please also add a comment when you set assign multiple to explain why 
you're doing it.

> Many RM unit tests failing with FairScheduler
> ---------------------------------------------
>
>                 Key: YARN-7146
>                 URL: https://issues.apache.org/jira/browse/YARN-7146
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0-beta1
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: YARN-7146.001.patch, YARN-7146.002.patch
>
>
> Many of the RM unit tests are failing when using the FairScheduler.  
> Here is a list of affected test classes:
> {noformat}
> TestYarnClient
> TestApplicationCleanup
> TestApplicationMasterLauncher
> TestDecommissioningNodesWatcher
> TestKillApplicationWithRMHA
> TestNodeBlacklistingOnAMFailures
> TestRM
> TestRMAdminService
> TestRMRestart
> TestResourceTrackerService
> TestWorkPreservingRMRestart
> TestAMRMRPCNodeUpdates
> TestAMRMRPCResponseId
> TestAMRestart
> TestApplicationLifetimeMonitor
> TestNodesListManager
> TestRMContainerImpl
> TestAbstractYarnScheduler
> TestSchedulerUtils
> TestFairOrderingPolicy
> TestAMRMTokens
> TestDelegationTokenRenewer
> {noformat}
> Most of the test methods in these classes are failing, though some do succeed.
> There's two main categories of issues:
> # The test submits an application to the {{MockRM}} and waits for it to enter 
> a specific state, which it never does, and the test times out.  We need to 
> call {{update()}} on the scheduler.
> # The test throws a {{ClassCastException}} on {{FSQueueMetrics}} to 
> {{CSQueueMetrics}}.  This is because {{QueueMetrics}} metrics are static, and 
> a previous test using FairScheduler initialized it, and the current test is 
> using CapacityScheduler.  We need to reset the metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to