[ 
https://issues.apache.org/jira/browse/YARN-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159989#comment-16159989
 ] 

Daniel Templeton commented on YARN-4090:
----------------------------------------

Thanks for the updated patch, [~yufeigu].  Two comments.  First the management 
of preempted containers' resources seems to run at odds with YARN-7057.  Maybe 
update this patch after you commit that one?  Second, note that the CS 
{{AbstractCSQueue}} has {{incUsedResource()}} and {{decUsedResource()}} methods 
already.  Maybe in the interest of commonality you could see if it's worth 
pushing those up to {{Queue}} and using them instead of adding your own methods 
for FS.

> Make Collections.sort() more efficient by caching resource usage
> ----------------------------------------------------------------
>
>                 Key: YARN-4090
>                 URL: https://issues.apache.org/jira/browse/YARN-4090
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Xianyin Xin
>            Assignee: Yufei Gu
>         Attachments: sampling1.jpg, sampling2.jpg, YARN-4090.001.patch, 
> YARN-4090.002.patch, YARN-4090.003.patch, YARN-4090.004.patch, 
> YARN-4090.005.patch, YARN-4090.006.patch, YARN-4090.007.patch, 
> YARN-4090-preview.patch, YARN-4090-TestResult.pdf
>
>
> Collections.sort() consumes too much time in a scheduling round.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to