[ https://issues.apache.org/jira/browse/YARN-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164901#comment-16164901 ]
Varun Saxena commented on YARN-7187: ------------------------------------ [~leftnoteasy], cherry-picked YARN-5719 into branch-2. One more issue in code seems to be that we calculate strlen on every iteration of for loop, which would be suboptimal. > branch-2 native compilation broken in hadoop-yarn-server-nodemanager > -------------------------------------------------------------------- > > Key: YARN-7187 > URL: https://issues.apache.org/jira/browse/YARN-7187 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Varun Saxena > Priority: Blocker > Attachments: YARN-7187-branch-2.01.patch, YARN-7187-branch-2.patch > > > {noformat} > [WARNING] make[2]: Leaving directory > `/home/root1/Projects/Branch2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native' > [WARNING] make[1]: Leaving directory > `/home/root1/Projects/Branch2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/native' > [WARNING] > /home/root1/Projects/Branch2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/string-utils.c: > In function ‘all_numbers’: > [WARNING] > /home/root1/Projects/Branch2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/string-utils.c:33:3: > error: ‘for’ loop initial declarations are only allowed in C99 mode > [WARNING] for (int i = 0; i < strlen(input); i++) { > [WARNING] ^ > [WARNING] > /home/root1/Projects/Branch2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/string-utils.c:33:3: > note: use option -std=c99 or -std=gnu99 to compile your code > [WARNING] make[2]: *** > [CMakeFiles/container.dir/main/native/container-executor/impl/utils/string-utils.c.o] > Error 1 > [WARNING] make[2]: *** Waiting for unfinished jobs.... > [WARNING] > /home/root1/Projects/Branch2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c: > In function ‘tokenize_docker_command’: > [WARNING] > /home/root1/Projects/Branch2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c:1193:7: > warning: unused variable ‘c’ [-Wunused-variable] > [WARNING] int c = 0; > [WARNING] ^ > [WARNING] make[1]: *** [CMakeFiles/container.dir/all] Error 2 > [WARNING] make: *** [all] Error 2 > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org