[ https://issues.apache.org/jira/browse/YARN-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168238#comment-16168238 ]
Miklos Szegedi commented on YARN-7192: -------------------------------------- Thank you [~asuresh] for the updated patch. bq. Hmm.. it is not technically needed, I just prefer it to having if checks. Do you have a strong preference against it ? I do not think it is blocking. A single null check in a function consumes less CPU cycles than a fetch + call and a ret to a virtual function. There are two cases it can cause a problem. Code ran very frequently like this may add up and make the overall product slower. It creates a precedence that others will follow, and it may cause performance issues in other code added later. Similarly, I would fix the checkstyle issues. It is much easier to capture and fix new checkstyle issues later if there are only a few of them in the file at least in some developer environments. Again, I think this is not blocking either. > Add a pluggable StateMachine Listener that is notified of NM Container State > changes > ------------------------------------------------------------------------------------ > > Key: YARN-7192 > URL: https://issues.apache.org/jira/browse/YARN-7192 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Arun Suresh > Assignee: Arun Suresh > Attachments: YARN-7192.001.patch, YARN-7192.002.patch, > YARN-7192.003.patch > > > This JIRA is to add support for a plugggable class in the NodeManager that is > notified of changes to the Container StateMachine state and the events that > caused the change. > The proposal is to modify the basic StateMachine class add support for a hook > that is called before and after a transition. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org