[
https://issues.apache.org/jira/browse/YARN-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168397#comment-16168397
]
Arun Suresh commented on YARN-7203:
-----------------------------------
Thanks for the patch [~botong]
Some comments:
* You don't need to create new methods to convert the Exectype in
{{ContainerReportPBImpl}}. You should just directly use ProtoUtils.convert
methods.
* In the following snippet, since you want the default value to be GUARANTEED,
make sure you return GUARANTEED, since out PBImpls are wrappers.
{code}
public ExecutionType getExecutionType() {
ContainerReportProtoOrBuilder p = viaProto ? proto : builder;
if (!p.hasExecutionType()) {
return null;
}
return convertFromProtoFormat(p.getExecutionType());
}
{code}
> Add container ExecutionType into ContainerReport
> ------------------------------------------------
>
> Key: YARN-7203
> URL: https://issues.apache.org/jira/browse/YARN-7203
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Botong Huang
> Assignee: Botong Huang
> Priority: Minor
> Attachments: YARN-7203.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
