[
https://issues.apache.org/jira/browse/YARN-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181132#comment-16181132
]
Billie Rinaldi commented on YARN-7191:
--------------------------------------
Thanks for the documentation patch, [~jianhe]! Some comments:
* Instead of using "http://myContainer.myDomain.com/endpoint"; as an example
endpoint, I think it would be better to use an example URL in the actual
registry DNS format. We could reuse the hbase master endpoint example, or
another example such as
"http://solr-0.solr-service.devuser.yarncluster:8983/solr/admin/collections?action=LIST";
* /28 16 IPs seems like a small number. I think we should change the example to
use /27 (32 IPs) or /26 (64 IPs) so we don't give the wrong impression that
only a few IPs can be assigned for docker containers.
* Instead of dev, we should name the example user something like devuser so
that it is clear from the URL which element is the user.
It's a little confusing that this patch contains some of my documentation
changes from YARN-7198 but not all of them. Do you think we should make all the
doc changes in this patch and remove them from the other patch, or should I
plan to do the remaining doc cleanup in YARN-7198?
> Improve yarn-service documentation
> ----------------------------------
>
> Key: YARN-7191
> URL: https://issues.apache.org/jira/browse/YARN-7191
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-7191.yarn-native-services.01.patch,
> YARN-7191.yarn-native-services.02.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
