[ https://issues.apache.org/jira/browse/YARN-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193977#comment-16193977 ]
Wangda Tan commented on YARN-7237: ---------------------------------- Thanks [~templedf], I just created YARN-7292, let's move additional feature behavior cleans to YARN-7292. bq. Given that we're considering removing the min/max profiles, I'll let the additional tests to validate that the min/max profiles are properly disallowed slide. Sorry I'm not sure what tests to change, did you mean new tests need to be added to YARN-7292? bq. Can you please clean up the checkstyle issues first? Cleaned up checkstyle issues include unused imports and long line, etc. Please find the attached ver.7 patch. > Cleanup usages of ResourceProfiles > ---------------------------------- > > Key: YARN-7237 > URL: https://issues.apache.org/jira/browse/YARN-7237 > Project: Hadoop YARN > Issue Type: Sub-task > Components: nodemanager, resourcemanager > Reporter: Wangda Tan > Assignee: Wangda Tan > Priority: Critical > Attachments: YARN-7237.001.patch, YARN-7237.002.patch, > YARN-7237.003.patch, YARN-7237.004.patch, YARN-7237.005.patch > > > While doing tests, there're a couple of issues: > 1) When use {{ProfileCapability#getProfileCapabilityOverride}}, it does > overwrite of whatever specified in resource-profiles.json when value >= 0. > Which is different from javadocs of {{ProfileCapability}} > bq. For example, if you have a resource profile "small" that maps to <4096M, > 2 cores, 1 gpu> and you set the capability override to <8192M, 0 cores, 0 > gpu>, then the actual resource allocation on the ResourceManager will be > <8192M, 2 cores, 1 gpu> > To me, the correct behavior should do overwrite when value > 0. The reason > is, by default resource value will be set to 0, For example, assume we have a > profile {{"a" = (mem=3, vcore=5, res_1=7)}}, and create a > capability-overwrite (capability = new resource(8). The final result should > be (mem=8, vcore=5, res_1=7), instead of (mem=8, vcore=0, res_1=0). > 2) ResourceProfileManager now loads minimum/maximum profile from config file > (resource-profiles.json), to me this is not correct because minimum/maximum > allocation for each resource types are already specified inside > {{resource-types.xml}}. We should always use > {{ResourceUtils#getResourceTypesMinimum/MaximumAllocation}} to get from > resource-types.xml and yarn-site.xml. This value will be added to profiles so > client can get these configs. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org