[ https://issues.apache.org/jira/browse/YARN-7308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205578#comment-16205578 ]
Yufei Gu commented on YARN-7308: -------------------------------- Thanks [~rkanter] for working on this. Looks good to me overall. Nits: # how about use parameter to test both CS and FS no matter what scheduler yarn-default.xml sets? In that sense, anyone modifying this class needs to make sure both can pass. # {{setup()}} seems pretty long. Do you mind putting fair scheduler configuration into separate method? > TestApplicationACLs fails with FairScheduler > -------------------------------------------- > > Key: YARN-7308 > URL: https://issues.apache.org/jira/browse/YARN-7308 > Project: Hadoop YARN > Issue Type: Bug > Components: test > Reporter: Robert Kanter > Assignee: Robert Kanter > Attachments: YARN-7308.001.patch > > > {{TestApplicationACLs}} fails when using FairScheduler: > {noformat} > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 98.389 sec > <<< FAILURE! - in > org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs > testApplicationACLs(org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs) > Time elapsed: 94.563 sec <<< FAILURE! > java.lang.AssertionError: App State is not correct (timeout). > expected:<FAILED> but was:<ACCEPTED> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at > org.apache.hadoop.yarn.server.resourcemanager.MockRM.waitForState(MockRM.java:284) > at > org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs.verifyInvalidQueueWithAcl(TestApplicationACLs.java:422) > at > org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs.testApplicationACLs(TestApplicationACLs.java:186) > {noformat} > There's a bunch of messages like this in the output: > {noformat} > 2017-10-09 17:00:54,572 INFO [main] resourcemanager.MockRM > (MockRM.java:waitForState(277)) - App : application_1507593559080_0006 State > is : ACCEPTED Waiting for state : FAILED > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org