[ https://issues.apache.org/jira/browse/YARN-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212845#comment-16212845 ]
Eric Yang commented on YARN-7353: --------------------------------- Thank you [~ebadger]. The test passes on CentOS 7. +1 I just committed this. > Docker permitted volumes don't properly check for directories > ------------------------------------------------------------- > > Key: YARN-7353 > URL: https://issues.apache.org/jira/browse/YARN-7353 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn > Reporter: Eric Badger > Assignee: Eric Badger > Attachments: YARN-7353.001.patch, YARN-7353.002.patch, > YARN-7353.003.patch > > > {noformat:title=docker-util.c:check_mount_permitted()} > // directory check > permitted_mount_len = strlen(permitted_mounts[i]); > if (permitted_mount_len > 0 > && permitted_mounts[i][permitted_mount_len - 1] == '/') { > if (strncmp(normalized_path, permitted_mounts[i], permitted_mount_len) > == 0) { > ret = 1; > break; > } > } > {noformat} > This code will treat "/home/" as a directory, but not "/home" > {noformat} > [ FAILED ] 3 tests, listed below: > [ FAILED ] TestDockerUtil.test_check_mount_permitted > [ FAILED ] TestDockerUtil.test_normalize_mounts > [ FAILED ] TestDockerUtil.test_add_rw_mounts > {noformat} > Additionally, YARN-6623 introduced new test failures in the C++ > container-executor test "cetest" -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org