[ https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736035#comment-13736035 ]
Jian He commented on YARN-353: ------------------------------ Looks good overall, few nits {code} for (int retries = 0; retries < numRetries && zkClient == null; retries++) { zkClient = getNewZooKeeper(); } {code} If getNewZooKeeper throws an Exception, it will break out of the loop, instead of retry again ? is it necessary to put a try/catch block around it ? bq. We are calling createWithRetries on multiple roots 'zkRootNodePath' is in fact the common root for 'rmDTSecretManagerRoot' and 'rmAppRoot', or we can at least new ZooKeeper along with'znodeWorkingPath'? I missed one change in my earlier patch, change 'yarn.resourcemanager.zk.rm-state-store.address' to 'yarn.resourcemanager.zk.state-store.address', can you fix this, thanks. > Add Zookeeper-based store implementation for RMStateStore > --------------------------------------------------------- > > Key: YARN-353 > URL: https://issues.apache.org/jira/browse/YARN-353 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Hitesh Shah > Assignee: Bikas Saha > Attachments: YARN-353.10.patch, YARN-353.11.patch, YARN-353.12.patch, > yarn-353-12-wip.patch, YARN-353.1.patch, YARN-353.2.patch, YARN-353.3.patch, > YARN-353.4.patch, YARN-353.5.patch, YARN-353.6.patch, YARN-353.7.patch, > YARN-353.8.patch, YARN-353.9.patch > > > Add store that write RM state data to ZK -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira