[
https://issues.apache.org/jira/browse/YARN-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222830#comment-16222830
]
Eric Payne commented on YARN-7370:
----------------------------------
Thanks [~GergelyNovak] for the work on this patch. I just have a couple of
small issues with the patch and one suggestion.
- {{ProportionalCapacityPreemptionPolicy}} has an unused import of
{{YarnConfiguration}}
- In {{ProportionalCapacityPreemptionPolicy#updateConfigIfNeeded}}, can we
switch the names of the local {{csConfig}} variable and the global class
instance variable {{config}}? My opinion is that a class instance variable
should have the more descriptive name.
- It would be nice if {{updateConfigIfNeeded}} would LOG the values of all of
the properties so that we have a record in the RM syslog whenever the values
are refreshed.
> Preemption properties should be refreshable
> -------------------------------------------
>
> Key: YARN-7370
> URL: https://issues.apache.org/jira/browse/YARN-7370
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, scheduler preemption
> Affects Versions: 2.8.0, 3.0.0-alpha3
> Reporter: Eric Payne
> Assignee: Gergely Novák
> Attachments: YARN-7370.001.patch
>
>
> At least the properties for {{max-allowable-limit}} and {{minimum-threshold}}
> should be refreshable. It would also be nice to make
> {{intra-queue-preemption.enabled}} and {{preemption-order-policy}}
> refreshable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
