[
https://issues.apache.org/jira/browse/YARN-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223838#comment-16223838
]
Sunil G commented on YARN-7159:
-------------------------------
Thanks [~maniraj...@gmail.com].
Some more comments
# In {{ResourceUtils.getNodeResourceInformation}} also, its better to normalize
the resource to what is already loaded as per *resouorce-types.xml* (if this
conf is available, usually when u run RM and NM in same machine, both files
could be there)
# Lets add more tests to TestResourcePBImpl in cases like a smaller unit is
converted to a higher one and vice versa.
# Another scenario is when one NM loads resource in GB (memory) as per
node-resource.xml and verify whther NM is registered with units MB. This test
case is better to add.
> Normalize unit of resource objects in RM and avoid to do unit conversion in
> critical path
> -----------------------------------------------------------------------------------------
>
> Key: YARN-7159
> URL: https://issues.apache.org/jira/browse/YARN-7159
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Wangda Tan
> Assignee: Manikandan R
> Priority: Critical
> Attachments: YARN-7159.001.patch, YARN-7159.002.patch,
> YARN-7159.003.patch, YARN-7159.004.patch, YARN-7159.005.patch
>
>
> Currently resource conversion could happen in critical code path when
> different unit is specified by client. This could impact performance and
> throughput of RM a lot. We should do unit normalization when resource passed
> to RM and avoid expensive unit conversion every time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
