[
https://issues.apache.org/jira/browse/YARN-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225713#comment-16225713
]
Billie Rinaldi commented on YARN-7371:
--------------------------------------
Thanks for the patch, [~csingh]! The patch looks good overall, I just have a
couple of small comments:
* since allocateId is changed to an int in ServiceScheduler, I think we should
change the Component constructor to take allocateId as an int, and we no longer
need to cast allocateId to an int in Priority.newInstance((int) allocateId) in
the constructor
{code}
Component(
org.apache.hadoop.yarn.service.api.records.Component component,
long allocateId, ServiceContext context)
{code}
* some of the checkstyle issues look easy to fix, specifically the cases where
lines are too long and where a curly brace is on the wrong line
> NPE in ServiceMaster after RM is restarted and then the ServiceMaster is
> killed
> -------------------------------------------------------------------------------
>
> Key: YARN-7371
> URL: https://issues.apache.org/jira/browse/YARN-7371
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Attachments: YARN-7371-yarn-native-services.001.patch,
> YARN-7371-yarn-native-services.002.patch,
> YARN-7371-yarn-native-services.003.patch
>
>
> java.lang.NullPointerException
> at
> org.apache.hadoop.yarn.service.ServiceScheduler.recoverComponents(ServiceScheduler.java:313)
> at
> org.apache.hadoop.yarn.service.ServiceScheduler.serviceStart(ServiceScheduler.java:265)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194)
> at
> org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:121)
> at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194)
> at org.apache.hadoop.yarn.service.ServiceMaster.main(ServiceMaster.java:150)
> Steps:
> 1. Stopped RM and then started it
> 2. Application was still running
> 3. Killed the ServiceMaster to check if it recovers
> 4. Next attempt failed with the above exception
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
