[
https://issues.apache.org/jira/browse/YARN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738519#comment-13738519
]
Zhijie Shen commented on YARN-979:
----------------------------------
There're some high-level comments on the patch:
1. To make the protocol work, it is required to define the corresponding protos
in yarn_service.proto and update pplication_history_service.proto
2. The setter of the request/response APIs should be @Public, shouldn't it?
3. It's required to mark ApplicationHistoryProtocol as well.
> [YARN-321] Adding application attempt and container to
> ApplicationHistoryProtocol
> ---------------------------------------------------------------------------------
>
> Key: YARN-979
> URL: https://issues.apache.org/jira/browse/YARN-979
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Mayank Bansal
> Assignee: Mayank Bansal
> Attachments: YARN-979-1.patch
>
>
> Adding application attempt and container to ApplicationHistoryProtocol
> Thanks,
> Mayank
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
