[ 
https://issues.apache.org/jira/browse/YARN-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236916#comment-16236916
 ] 

Subru Krishnan edited comment on YARN-7434 at 11/3/17 1:25 AM:
---------------------------------------------------------------

Thanks [~elgoiri] for the patch, LGTM overall. Couple of minor comments:
* Can we move the local copy of members outside of *clone* as its invoked in 
loop?
* The patch itself looks quite straightforward but I am not sure how involved 
it is add multi-thread, i.e. multi - RM tests?


was (Author: subru):
Thanks [~elgoiri] for the patch, couple of comments:
* Can we move the local copy of members outside of *clone* as its invoked in 
loop?
* The patch itself looks quite straightforward but I am not sure how involved 
it is add multi-thread, i.e. multi - RM tests?

> Router getApps REST invocation fails with multiple RMs
> ------------------------------------------------------
>
>                 Key: YARN-7434
>                 URL: https://issues.apache.org/jira/browse/YARN-7434
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Subru Krishnan
>            Assignee: Íñigo Goiri
>            Priority: Critical
>         Attachments: YARN-7434.000.patch, YARN-7434.001.patch
>
>
> Router uses threads to invoke getApps in parallel with multiple RMs and has a 
> concurrency bug caused by sharing of the HTTP request object. This jira 
> tracks the changes to fix the multi-threading issue by cloning the request.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to