[ 
https://issues.apache.org/jira/browse/YARN-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238188#comment-16238188
 ] 

Miklos Szegedi commented on YARN-1015:
--------------------------------------

Thank you for the patch [~haibochen].
{code}
387           
{code\}yarn.nodemanager.overallocation.memory-utilization-threshold \{code\}
388           and
389           \{code\}yarn.nodemanager.overallocation.cpu-utilization-threshold 
\{code\}
{code}
There are two unnecessary spaces in the code sections
{code}
854         Resource available = opportunistic ?
855             node.allowedResourceForOverAllocation() : 
node.getUnallocatedResource();
{code}
assignContainer is not synchronized. Could the allowed resource for 
overallocation change later while the function is still running?


> FS should watch node resource utilization and allocate opportunistic 
> containers if appropriate
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-1015
>                 URL: https://issues.apache.org/jira/browse/YARN-1015
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun C Murthy
>            Assignee: Haibo Chen
>            Priority: Major
>         Attachments: YARN-1015-YARN-1011.00.patch, 
> YARN-1015-YARN-1011.01.patch, YARN-1015-YARN-1011.prelim.patch
>
>
> FS should looks at resource utilization of nodes (provided by NM in 
> heartbeat) and allocate opportunistic containers if the resource utilization 
> of the node is below its allocation threshold.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to