[ https://issues.apache.org/jira/browse/YARN-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242572#comment-16242572 ]
Soumabrata Chakraborty edited comment on YARN-7414 at 11/7/17 6:24 PM: ----------------------------------------------------------------------- Attached patch 002 Code Review comments from [~templedf] implemented in this patch was (Author: soumabrata): Attached patch 002 > FairScheduler#getAppWeight() should be moved into FSAppAttempt#getWeight() > -------------------------------------------------------------------------- > > Key: YARN-7414 > URL: https://issues.apache.org/jira/browse/YARN-7414 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Affects Versions: 3.0.0-beta1 > Reporter: Daniel Templeton > Assignee: Soumabrata Chakraborty > Priority: Minor > Labels: newbie > Attachments: YARN-7414.001.patch, YARN-7414.002.patch > > > It's illogical that {{FSAppAttempt}} defers to {{FairScheduler}} for its own > weight, especially when {{FairScheduler}} has to call back to > {{FSAppAttempt}} to get the details to return a value. Instead, > {{FSAppAttempt}} should do the work and call out to {{FairScheduler}} to get > the details it needs. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org