[
https://issues.apache.org/jira/browse/YARN-7388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243119#comment-16243119
]
Robert Kanter commented on YARN-7388:
-------------------------------------
Looks good overall. A few minor things:
# Can you add Javadoc to {{AbstractYarnScheduler#killContainer}}?
# The arguments for {{completedContainer}} in {{FairScheduler#killContainer}}
can fit on one line.
# I'm not an expert here, but it seems funny to me that we're preempting a
container when we kill it; it seems especially strange if this were to happen
when preemption were turned off...
> TestAMRestart should be scheduler agnostic
> ------------------------------------------
>
> Key: YARN-7388
> URL: https://issues.apache.org/jira/browse/YARN-7388
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha4
> Reporter: Haibo Chen
> Assignee: Haibo Chen
> Attachments: YARN-7388.00.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
