[
https://issues.apache.org/jira/browse/YARN-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248293#comment-16248293
]
Arun Suresh commented on YARN-7438:
-----------------------------------
Thanks for working on this [~wangda],
In general I think your refactoring makes things more intuitive - I really did
not like the ResourceRequest :)
Am wondering if the ContainerRequest could be more like the
AMRMClient#ContainerRequest - or we can use {{SchedulingRequest}} itself
(Apologize for the delay in the patch - I will post it as soon as YARN-6595 is
done.)
bq. So in the future we probably will add an updateSchedulingRequest in
parallel with updateResourceRequests
Hmm... lets see if can keep it as updateSchedulingRequest itself - like I asked
earlier offline, do you see a case where the old List<ResourceRequest> is more
expressive than the SchedulingRequest ?
I will give this a closer look over the weekend.
> Additional changes to make SchedulingPlacementSet agnostic to ResourceRequest
> / placement algorithm
> ---------------------------------------------------------------------------------------------------
>
> Key: YARN-7438
> URL: https://issues.apache.org/jira/browse/YARN-7438
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-7438.001.patch
>
>
> In additional to YARN-6040, we need to make changes to SchedulingPlacementSet
> to make it:
> 1) Agnostic to ResourceRequest (so once we have YARN-6592 merged, we can add
> new SchedulingPlacementSet implementation in parallel with
> LocalitySchedulingPlacementSet to use/manage new requests API)
> 2) Agnostic to placement algorithm (now it is bind to delayed scheduling, we
> should update APIs to make sure new placement algorithms such as complex
> placement algorithms can be implemented by using SchedulingPlacementSet).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
