[ 
https://issues.apache.org/jira/browse/YARN-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250868#comment-16250868
 ] 

Sunil G commented on YARN-7462:
-------------------------------

[~skmvasu] Thanks for the patch.

I have one issue in this patch. Post YARN-3926, we support more resource types 
other than memory and vcores.
But REST endpoint 
org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ResourceInfo is not 
having multiple resource support in a clean way. So post this patch, we need to 
raise a common ticket in UI to show resources other than memory and cpu also.

Some minor comments:
# {{.history/}} is added to git ignore list. Why this is needed?
# Rename {{Priority}} to {{Scheduler Key}}
# {{ResourceName}} to {{Resource Name}}. A space to be added for better 
readability
# {{NumContainers}}. Could we say like {{# Containers}} as it indicates a count.
# {{Outstanding resource requests}} to {{Outstanding Resource Requests}}
# If {{model.app.resourceRequests}} is empty, could we hide the whole table?

> Render outstanding resource requests on application details page
> ----------------------------------------------------------------
>
>                 Key: YARN-7462
>                 URL: https://issues.apache.org/jira/browse/YARN-7462
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn-ui-v2
>            Reporter: Vasudevan Skm
>            Assignee: Vasudevan Skm
>         Attachments: Screen Shot 2017-11-08 at 3.24.30 PM.png, Screen Shot 
> 2017-11-08 at 3.38.48 PM.png, YARN-7462.001.patch, YARN-7462.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to