[ 
https://issues.apache.org/jira/browse/YARN-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257127#comment-16257127
 ] 

Zheng Hu edited comment on YARN-7213 at 11/17/17 3:41 PM:
----------------------------------------------------------

[~haibo.chen],  I written a UT based on your HBase folks discussion.  Actually 
it'll be failed running on both 2.0.0-beta-1 and branch-1.1 branch (the logic 
of Filter in branch-1.1 does not changed), and it should be failed logically.  

The  testDirectScan UT your provided,  What is the data in this table?  I want 
to test it independently of the yarn test environment, and just in hbase 
MiniCluster. 

{code}
  @Test
  public void testFilterListWithSingleColumnValueFilterAndFamilyFilter() throws 
IOException {
    TableName tn = TableName.valueOf(name.getMethodName());
    try (Table table = TEST_UTIL.createTable(tn, new String[] { "cf1", "cf2" 
})) {
      String[][] cells = new String[][] {
              new String[] { "row1", "cf1", "cq1", "value1" },
              new String[] { "row1", "cf1", "cq2", "value1" },
              new String[] { "row1", "cf2", "cq1", "value2" },
          };
      for (int i = 0; i < cells.length; i++) {
        Put put =
            new 
Put(Bytes.toBytes(cells[i][0])).addColumn(Bytes.toBytes(cells[i][1]),
              Bytes.toBytes(cells[i][2]), Bytes.toBytes(cells[i][3]));
        table.put(put);
      }

      SingleColumnValueFilter svf1 =
          new SingleColumnValueFilter(Bytes.toBytes("cf1"), 
Bytes.toBytes("cq2"),
              CompareOperator.EQUAL, new 
BinaryComparator(Bytes.toBytes("value1")));

      FilterList filterList = new FilterList(FilterList.Operator.MUST_PASS_ALL);
      filterList.addFilter(svf1);
      filterList.addFilter(new FamilyFilter(CompareOperator.EQUAL, new 
BinaryComparator("cf2"
              .getBytes())));

      Scan scan = new Scan().setFilter(filterList); 

      int i = 0;
      for (Result result : table.getScanner(scan)) {
        i++;
      }
      Assert.assertEquals("first scan", 1, i);

      svf1.setFilterIfMissing(true);
      i = 0;
      for (Result result : table.getScanner(scan)) {
        i++;
      }
      Assert.assertEquals("second scan", 1, i);
    }
  }
{code}


was (Author: openinx):
[~haibo.chen],  I written a UT based on your HBase folks discussion.  Actually 
it'll be failed running on both 2.0.0-beta-1 and branch-1.1 branch (the logic 
of Filter in branch-1.1 does not changed), and it should be failed logically.  

The  testDirectScan UT your provided,  What is the data in this table?  I want 
to test it independently of the yarn test environment, and just in hbase 
MiniCluster. 

{code}
  @Test
  public void testFilterListWithSingleColumnValueFilterAndFamilyFilter() throws 
IOException {
    TableName tn = TableName.valueOf(name.getMethodName());
    try (Table table = TEST_UTIL.createTable(tn, new String[] { "cf1", "cf2" 
})) {
      String[][] cells = new String[][] {
              new String[] { "row1", "cf1", "cq1", "value1" },
              new String[] { "row1", "cf1", "cq2", "value1" },
              new String[] { "row1", "cf2", "cq1", "value2" },
          };
      for (int i = 0; i < cells.length; i++) {
        Put put =
            new 
Put(Bytes.toBytes(cells[i][0])).addColumn(Bytes.toBytes(cells[i][1]),
              Bytes.toBytes(cells[i][2]), Bytes.toBytes(cells[i][3]));
        table.put(put);
      }

      SingleColumnValueFilter svf1 =
          new SingleColumnValueFilter(Bytes.toBytes("cf1"), 
Bytes.toBytes("cq2"),
              CompareOperator.EQUAL, new 
BinaryComparator(Bytes.toBytes("value1")));

      FilterList filterList = new FilterList(FilterList.Operator.MUST_PASS_ALL);
      filterList.addFilter(svf1);
      filterList.addFilter(new FamilyFilter(CompareOperator.EQUAL, new 
BinaryComparator("cf2"
              .getBytes())));

      Scan scan = new Scan().setFilter(filterList); // copy the scan

      int i = 0;
      for (Result result : table.getScanner(scan)) {
        i++;
      }
      Assert.assertEquals("first scan", 1, i);

      svf1.setFilterIfMissing(true);
      i = 0;
      for (Result result : table.getScanner(scan)) {
        i++;
      }
      Assert.assertEquals("second scan", 1, i);
    }
  }
{code}

> [Umbrella] Test and validate HBase-2.0.x with Atsv2
> ---------------------------------------------------
>
>                 Key: YARN-7213
>                 URL: https://issues.apache.org/jira/browse/YARN-7213
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: YARN-7213.prelim.patch, YARN-7213.wip.patch
>
>
> Hbase-2.0.x officially support hadoop-alpha compilations. And also they are 
> getting ready for Hadoop-beta release so that HBase can release their 
> versions compatible with Hadoop-beta. So, this JIRA is to keep track of 
> HBase-2.0 integration issues. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to