[ 
https://issues.apache.org/jira/browse/YARN-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266206#comment-16266206
 ] 

Yufei Gu commented on YARN-7535:
--------------------------------

Max resource is a hard limit, which means a queue can't use more resources than 
its max resources. Hence, demand and usage shouldn't be greater than max 
resources. The exiting code makes sense to me in that sense. Should we display 
the original demand other than normalized one? I am open to suggestions, and 
would like to hear more about why needs to show the original. cc [~wilfreds]

> We should display origin value of demand in fair scheduler page
> ---------------------------------------------------------------
>
>                 Key: YARN-7535
>                 URL: https://issues.apache.org/jira/browse/YARN-7535
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>            Reporter: YunFan Zhou
>            Assignee: YunFan Zhou
>
> The value of *demand* of leaf queue that we now view on the fair scheduler 
> page shows only the value of *maxResources* when the demand value is greater 
> than *maxResources*. It doesn't reflect the real situation. Most of the time, 
> when we expand the queue, we often rely on seeing the current demand real 
> value.
> {code:java}
> private void updateDemandForApp(FSAppAttempt sched, Resource maxRes) {
>     sched.updateDemand();
>     Resource toAdd = sched.getDemand();
>     if (LOG.isDebugEnabled()) {
>       LOG.debug("Counting resource from " + sched.getName() + " " + toAdd
>           + "; Total resource consumption for " + getName() + " now "
>           + demand);
>     }
>     demand = Resources.add(demand, toAdd);
>     demand = Resources.componentwiseMin(demand, maxRes);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to