[ https://issues.apache.org/jira/browse/YARN-7537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270127#comment-16270127 ]
Vrushali C commented on YARN-7537: ---------------------------------- Thanks Rohith for the clarification, patch looks good overall. A few minor suggestions: - remove the MalformedURLException import, I guess it's no longer needed. - rename the configuration file variable timelineServiceHBaseConfFileURL to not contain "URL" since it's no longer an URL. Perhaps call it timelineServiceHBaseConfFilePath ? Another thing I was wondering is, so looks like we will be changing this public API? Are there any guidelines around how apis are to be changed? Do we need to call it out in the next release? Do we need to first mark it deprecated and provide another new API and then later on remove it? > [Atsv2] load hbase configuration from filesystem rather than URL > ---------------------------------------------------------------- > > Key: YARN-7537 > URL: https://issues.apache.org/jira/browse/YARN-7537 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Rohith Sharma K S > Assignee: Rohith Sharma K S > Attachments: YARN-7537.01.patch > > > Currently HBaseTimelineStorageUtils#getTimelineServiceHBaseConf loads hbase > configurations using URL if *yarn.timeline-service.hbase.configuration.file* > is configured. But it is restricted to URLs only. This need to be changed to > load from file system. In deployment, hbase configuration can be kept under > filesystem so that it be utilized by all the NodeManager and ResourceManager. > cc :/ [~vrushalic] [~varun_saxena] -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org