[ https://issues.apache.org/jira/browse/YARN-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743055#comment-13743055 ]
Karthik Kambatla commented on YARN-1075: ---------------------------------------- Thanks [~stevel] and [~vinodkv]. Read through YARN-117, agree these changes are not required. Before I close this as invalid, just wondering if it would still make sense to include these changes to future-proof any additions to {{AbstractService#serviceStart()}}? If we are going to leave {{AbstractService#serviceStart()}} as an empty stub, it might be worth making it an abstract method. No? > AsyncDispatcher and ResourceTrackerService violate serviceStart() semantics > --------------------------------------------------------------------------- > > Key: YARN-1075 > URL: https://issues.apache.org/jira/browse/YARN-1075 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.1.0-beta > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Priority: Minor > Attachments: yarn-1075-1.patch > > > IIUC, the serviceStart() implementation of services should start local > threads/services first before calling super.serviceStart(). Certain services > have this reversed as below - leading to possibilities where the service > would be in state STARTED, but in reality might not have started yet. > {code} > void serviceStart() { > super.serviceStart() > // service sepecific logic and start operations > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira