[ 
https://issues.apache.org/jira/browse/YARN-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273604#comment-16273604
 ] 

Wangda Tan commented on YARN-7586:
----------------------------------

Thanks [~suma.shivaprasad], change looks straightforward to me.

One minor comment: 

{{// fail the submission if configured application timeout value is invalid}} 
should be moved as well, it is not original purpose of queue mapping logic. 

And is it possible to add an unit test to avoid future regression? 

[~sunilg], could you help to take this forward.

> Application Placement should be done before ACL checks in ResourceManager
> -------------------------------------------------------------------------
>
>                 Key: YARN-7586
>                 URL: https://issues.apache.org/jira/browse/YARN-7586
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Suma Shivaprasad
>            Assignee: Suma Shivaprasad
>            Priority: Blocker
>         Attachments: YARN-7586.1.patch
>
>
> YARN-7419 moved Application placement from RMAppManager to RMAppImpl which 
> causes issues since ApplicationSubmissionContext still has the original queue 
> specified by the user and not the mapped queue . This causes issues while 
> doing ACL checks in RMAppManager



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to