[
https://issues.apache.org/jira/browse/YARN-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274650#comment-16274650
]
Sunil G commented on YARN-7522:
-------------------------------
Thanks [~leftnoteasy].
Few doubts/comments
# As per offline talk with Wangda, its better to have NodeToCountedTags than
keeping its RMNode. It could avoid a lot of contentions.
# I have one more doubt here
{code}
55 // Application's tags to node
56 private Map<ApplicationId, NodeToCountedTags> perAppMappings =
57 new HashMap<>();
{code}
and
{code}
67 static class NodeToCountedTags {
68 // Map<NodeId, Map<Tag, Count>>
69 private Map<NodeId, Map<String, Long>> nodeToTagsWithCount =
70 new HashMap<>();
{code}
so for each app, it has app tags per node. in some worst cases, where multiple
apps consumes/runs containers in all nodes or most of nodes, we will have
multiple copy of nodes under each app?
# getCardinality does a loop to compute numValues? Could globalMapping to be
improved to keep a sum also?
> Add application tags manager implementation
> -------------------------------------------
>
> Key: YARN-7522
> URL: https://issues.apache.org/jira/browse/YARN-7522
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-7522.YARN-6592.002.patch,
> YARN-7522.YARN-6592.003.patch, YARN-7522.YARN-6592.wip-001.patch
>
>
> This is different from YARN-6596, YARN-6596 is targeted to add constraint
> manager to store intra/inter application placement constraints. This JIRA is
> targeted to support storing maps between container-tags/applications and
> nodes. This will be required by affinity/anti-affinity implementation and
> cardinality.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
