[ https://issues.apache.org/jira/browse/YARN-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278047#comment-16278047 ]
Wilfred Spiegelenburg commented on YARN-7562: --------------------------------------------- Some more comments: you added 3 tests which all do exactly the same. You only need to have one test that checks if a parent queue is returned or not. The code path for all is exactly the same. Instead of 3 tests we should just have one: testPolicyWithParentQueue(). If you want to test multiple rules you can do it from that one test by reinitialising the policy. Second point: inside the test you are parsing the policy twice, the second call to parse is not needed > queuePlacementPolicy should not match parent queue > -------------------------------------------------- > > Key: YARN-7562 > URL: https://issues.apache.org/jira/browse/YARN-7562 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Affects Versions: 2.7.1 > Reporter: chuanjie.duan > Attachments: YARN-7562.002.patch, YARN-7562.003.patch, > YARN-7562.004.patch, YARN-7562.005.patch, YARN-7562.006.patch, > YARN-7562.007.patch, YARN-7562.patch > > > User algo submit a mapreduce job, console log said "root.algo is not a leaf > queue exception". > root.algo is a parent queue, it's meanless for me. Not sure why parent queue > added before > <queue name="default"> > <minResources>3000 mb, 1 vcores</minResources> > <maxResources>24000 mb, 8 vcores</maxResources> > <maxRunningApps>4</maxRunningApps> > <weight>1</weight> > <schedulingMode>fifo</schedulingMode> > </queue> > <queue name="cim"> > <minResources>3000 mb, 1 vcores</minResources> > <maxResources>24000 mb, 8 vcores</maxResources> > <maxRunningApps>4</maxRunningApps> > <weight>1</weight> > <schedulingMode>fifo</schedulingMode> > </queue> > <queue name="algo"> > <minSharePreemptionTimeout>300</minSharePreemptionTimeout> > <minResources>40000 mb, 10 vcores</minResources> > <maxResources>200000 mb, 60 vcores</maxResources> > <queue name="testb"> > <minSharePreemptionTimeout>300</minSharePreemptionTimeout> > <minResources>40000 mb, 10 vcores</minResources> > <maxResources>100000 mb, 30 vcores</maxResources> > <maxRunningApps>20</maxRunningApps> > <schedulingMode>fifo</schedulingMode> > <weight>4</weight> > </queue> > <queue name="testa"> > <minSharePreemptionTimeout>300</minSharePreemptionTimeout> > <minResources>40000 mb, 10 vcores</minResources> > <maxResources>100000 mb, 30 vcores</maxResources> > <maxRunningApps>20</maxRunningApps> > <schedulingMode>fifo</schedulingMode> > <weight>4</weight> > </queue> > </queue> > <queuePlacementPolicy> > <rule name="user" create="false" /> > <rule name="specified" /> > <rule name="default" queue="default"/> > </queuePlacementPolicy> -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org