[ 
https://issues.apache.org/jira/browse/YARN-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280734#comment-16280734
 ] 

Gergely Novák commented on YARN-7242:
-------------------------------------

[~leftnoteasy] I'd love to work on this issue. The 2nd patch fixes the 
checkstyle issues and the broken unit test, however, it doesn't contain the new 
format you requested, because I have some questions regarding this: YARN-5881 
is not yet merged to trunk, so I cannot use any of that code. Should I create a 
custom util in the DistributedShell app that converts the above format to a 
Resource class? In YARN-5881 this logic is implemented in 
CapacitySchedulerConfiguration, I feel that the same logic should be extracted 
to a common class in order to eliminate any duplications, e.g. to Resource or 
ResourceUtils. Especially that the handling of the "memory" -> "memory-mb" 
conversion is not trivial and that the format should support expansion (new 
resource types and formats). 

> Support specify values of different resource types in DistributedShell for 
> easier testing
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-7242
>                 URL: https://issues.apache.org/jira/browse/YARN-7242
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Gergely Novák
>            Priority: Critical
>              Labels: newbie
>         Attachments: YARN-7242.001.patch
>
>
> Currently, DS supports specify resource profile, it's better to allow user to 
> directly specify resource keys/values from command line.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to