[
https://issues.apache.org/jira/browse/YARN-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285854#comment-16285854
]
Sunil G commented on YARN-7634:
-------------------------------
Thanks [~suma.shivaprasad]
Couple of minor nits.
# {{((CapacityScheduler)newMockRM.getResourceScheduler())}}, please extract
this to a local variable for better readability in test cases.
# Few indentation issues in test class and in all patch. Pls check checkstyle
and help to fix the same.
One doubt:
Currently we assume that parent queue's acl could be checked when queue is null
and placementContext is available. Here i have 2 doubts.
# Can this same condition hit in other cases like normal user-mapping etc.? or
*queue is null and placementContext is available* is the signature for auto
create leaf queue feature?
# If in future, when leaf queue template also have ACLs, how this could be
changed? or is there any plan for same?
> Queue ACL validations should validate parent queue ACLs before auto-creating
> leaf queues
> ----------------------------------------------------------------------------------------
>
> Key: YARN-7634
> URL: https://issues.apache.org/jira/browse/YARN-7634
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Suma Shivaprasad
> Assignee: Suma Shivaprasad
> Attachments: YARN-7634.1.patch
>
>
> RMAppManager currently validates only leaf queue ACLs and if leaf queue
> doesnt exist which is the case in auto-created leaf queues, queue mapping may
> return a parent queue. However Parent queue ACLs are not validated. This
> needs to be validated before auto-creating leaf queues for the mapped parent
> queue
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
