[ https://issues.apache.org/jira/browse/YARN-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291151#comment-16291151 ]
Jim Brennan commented on YARN-7595: ----------------------------------- This is ready for review for branch-2. > Container launching code suppresses close exceptions after writes > ----------------------------------------------------------------- > > Key: YARN-7595 > URL: https://issues.apache.org/jira/browse/YARN-7595 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Reporter: Jason Lowe > Assignee: Jim Brennan > Fix For: 3.1.0, 3.0.1 > > Attachments: YARN-7595-branch-2.001.patch, YARN-7595.001.patch, > YARN-7595.002.patch, YARN-7595.003.patch > > > There are a number of places in code related to container launching where the > following pattern is used: > {code} > try { > ...write to stream outStream... > } finally { > IOUtils.cleanupWithLogger(LOG, outStream); > } > {code} > Unfortunately this suppresses any IOException that occurs during the close() > method on outStream. If the stream is buffered or could otherwise fail to > finish writing the file when trying to close then this can lead to > partial/corrupted data without throwing an I/O error. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org