[
https://issues.apache.org/jira/browse/YARN-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291537#comment-16291537
]
Varun Saxena commented on YARN-7190:
------------------------------------
[~rohithsharma],
bq. I build and compared with branch-2, I see that jsr311-api-1.1.1 and
netty-all-4.0.23.Final jars are missing in trunk. Is it expected or missed?
In trunk, dev-support/bin/dist-layout-stitching script does not copy jars which
already exist somewhere inside share folder (say, inside hdfs, common, etc.).
As netty-all and jsr311-api jars exist in share/hadoop/hdfs/lib folder, they
are not copied to share/hadoop/yarn/timelineservice/lib. As
share/hadoop/hdfs/lib is part of YARN classpath, this should be fine.
The said behavior is not due to this patch. If we have to override this
behavior of dist-layout-stitching and decide on this behavior based on the
component in which duplicate jar was found, we may have to look at other jars
too and that wont be in the scope of this JIRA.
By the way, are you +1 on the patch otherwise? As the original patch has been
given by me, I would suggest either you or Vrushali review and commit it.
> Ensure only NM classpath in 2.x gets TSv2 related hbase jars, not the user
> classpath
> ------------------------------------------------------------------------------------
>
> Key: YARN-7190
> URL: https://issues.apache.org/jira/browse/YARN-7190
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineclient, timelinereader, timelineserver
> Reporter: Vrushali C
> Assignee: Varun Saxena
> Fix For: YARN-5355_branch2, 2.9.1
>
> Attachments: YARN-7190-YARN-5355_branch2.01.patch,
> YARN-7190-YARN-5355_branch2.02.patch, YARN-7190-YARN-5355_branch2.03.patch,
> YARN-7190.01.patch, YARN-7190.02.patch
>
>
> [~jlowe] had a good observation about the user classpath getting extra jars
> in hadoop 2.x brought in with TSv2. If users start picking up Hadoop 2,x's
> version of HBase jars instead of the ones they shipped with their job, it
> could be a problem.
> So when TSv2 is to be used in 2,x, the hbase related jars should come into
> only the NM classpath not the user classpath.
> Here is a list of some jars
> {code}
> commons-csv-1.0.jar
> commons-el-1.0.jar
> commons-httpclient-3.1.jar
> disruptor-3.3.0.jar
> findbugs-annotations-1.3.9-1.jar
> hbase-annotations-1.2.6.jar
> hbase-client-1.2.6.jar
> hbase-common-1.2.6.jar
> hbase-hadoop2-compat-1.2.6.jar
> hbase-hadoop-compat-1.2.6.jar
> hbase-prefix-tree-1.2.6.jar
> hbase-procedure-1.2.6.jar
> hbase-protocol-1.2.6.jar
> hbase-server-1.2.6.jar
> htrace-core-3.1.0-incubating.jar
> jamon-runtime-2.4.1.jar
> jasper-compiler-5.5.23.jar
> jasper-runtime-5.5.23.jar
> jcodings-1.0.8.jar
> joni-2.1.2.jar
> jsp-2.1-6.1.14.jar
> jsp-api-2.1-6.1.14.jar
> jsr311-api-1.1.1.jar
> metrics-core-2.2.0.jar
> servlet-api-2.5-6.1.14.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
