[
https://issues.apache.org/jira/browse/YARN-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292042#comment-16292042
]
Weiwei Yang commented on YARN-7617:
-----------------------------------
Hi [~asuresh]
Thanks for the detail notes. Actually I figured this out by reading the code as
well. That's why I called {{NMClientAsync#updateContainerResourceAsync}} to
inform NM about the type update, that works when {{auto-update.containers}} is
disabled. So I understand your point now, semantically there will be another
API {{updateContainer}} added to nm client to handle the container update
instead of using the {{updateContainerResource}} API. So currently the way I
used
{code}
nmClientAsync.updateContainerResourceAsync(container.getContainer());
{code}
this is temporary, and that should be replaced by the new API once it is done.
Correct?
Then, do you still want me to remove this line? Because if I removed that, user
needs to setup {{auto-update.containers}} to true otherwise the update won't
happen. Or remain the code and add a "TODO" that we can replace this call to
the new API once it is ready? I am personally prefer to the latter option, what
do you think?
Thanks
> Add a flag in distributed shell to automatically PROMOTE opportunistic
> containers to guaranteed once they are started
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-7617
> URL: https://issues.apache.org/jira/browse/YARN-7617
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: applications/distributed-shell
> Affects Versions: 2.9.0
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Minor
> Attachments: YARN-7617.001.patch, promote_containers.jpg
>
>
> Per discussion in YARN-7610, it would be good to add such a flag, e.g
> {{promote_opportunistic_after_start}}. This is for the purpose of
> demonstrating how container promotion works.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
