[ 
https://issues.apache.org/jira/browse/YARN-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292877#comment-16292877
 ] 

Sunil G commented on YARN-7619:
-------------------------------

Thanks [~eepayne].

Few more minor comments

# In LQ,
{code}
userAMLimit = Resources.lessThanOrEqual(resourceCalculator, lastClusterResource,
                  userAMLimit, getAMResourceLimitPerPartition(nodePartition)) ?
                  userAMLimit : getAMResourceLimitPerPartition(nodePartition);
{code}
I think we can use Resources.min here also.
# I think its an existing bug. In above code, 
{{getAMResourceLimitPerPartition(nodePartition)}} is returning stored Resource 
object (not clone). And this *userAMLimit* is later set to 
{{user.getResourceUsage()}} etc. Its better to use Resources.clone on this 
object, correct?

> Max AM Resource value in CS UI is different for every user
> ----------------------------------------------------------
>
>                 Key: YARN-7619
>                 URL: https://issues.apache.org/jira/browse/YARN-7619
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler, yarn
>    Affects Versions: 2.9.0, 3.0.0-beta1, 2.8.2, 3.1.0
>            Reporter: Eric Payne
>            Assignee: Eric Payne
>         Attachments: Max AM Resources is Different for Each User.png, 
> YARN-7619.001.patch, YARN-7619.002.patch, YARN-7619.003.patch, 
> YARN-7619.004.branch-2.8.patch, YARN-7619.004.branch-3.0.patch, 
> YARN-7619.004.patch
>
>
> YARN-7245 addressed the problem that the {{Max AM Resource}} in the capacity 
> scheduler UI used to contain the queue-level AM limit instead of the 
> user-level AM limit. It fixed this by using the user-specific AM limit that 
> is calculated in {{LeafQueue#activateApplications}}, stored in each user's 
> {{LeafQueue#User}} object, and retrieved via 
> {{UserInfo#getResourceUsageInfo}}.
> The problem is that this user-specific AM limit depends on the activity of 
> other users and other applications in a queue, and it is only calculated and 
> updated when a user's application is activated. So, when 
> {{CapacitySchedulerPage}} retrieves the user-specific AM limit, it is a stale 
> value unless an application was recently activated for a particular user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to