[ https://issues.apache.org/jira/browse/YARN-7669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298560#comment-16298560 ]
Sunil G commented on YARN-7669: ------------------------------- Thanks [~asuresh] and [~kkaranasos] Few doubts and comments in this patch. # How {{ApplicationMasterServiceUtils#addToRejectedSchedulingRequests}} is invoked? I could not find a caller or is it a part of some dependent tickets? # {{AllocateResponse#getRejectedSchedulingRequests}} gives rejected requests from previous allocate to current one. But will this info be retained at scheduler assuming RM restarted between AM heartbeats? Also one more doubt here, # Could {{RejectionReason}} also be used in cases like Node Constraints too? Its also possible that placement could fail may be node constraint also violated on a node. # In line with above comment, I think *RejectionReason* enum could only provide a very minimal reject reason. COULD_NOT_SCHEDULE_ON_NODE could happen due to multiple reasons. But I also think having a string to give diag is also too descriptive and AM's could not decode same. I think we could add more enums as error codes than giving a high level one error code like COULD_NOT_SCHEDULE_ON_NODE? > [API] Introduce interfaces for placement constraint processing > -------------------------------------------------------------- > > Key: YARN-7669 > URL: https://issues.apache.org/jira/browse/YARN-7669 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Arun Suresh > Attachments: YARN-7669-YARN-6592.001.patch, > YARN-7669-YARN-6592.002.patch, YARN-7669-YARN-6592.003.patch > > > As per discussions in YARN-7612. This JIRA will introduce the generic > interfaces which will be implemented in YARN-7612 -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org