[ 
https://issues.apache.org/jira/browse/YARN-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299005#comment-16299005
 ] 

Botong Huang edited comment on YARN-7676 at 12/20/17 8:03 PM:
--------------------------------------------------------------

Yeah, {{TestApplicationPriority}} indeed fails with v1 patch reversing the 
{{Priority}} order. So basically Application priority is using {{Priority}} 
assuming larger value means higher priority, but {{ResourceRequest}} is using 
{{Priority}} assuming smaller value means higher priority...


was (Author: botong):
Yeah, {{TestApplicationPriority}} indeed fails with v1 patch reversing the 
Priority order. So basically Application priority is using Priority assuming 
larger value means higher priority, but {{ResourceRequest}} is using Priority 
assuming smaller value means higher priority...

> Fix inconsistent priority ordering in Priority and SchedulerRequestKey
> ----------------------------------------------------------------------
>
>                 Key: YARN-7676
>                 URL: https://issues.apache.org/jira/browse/YARN-7676
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Minor
>         Attachments: YARN-7676.v1.patch
>
>
> Today the priority ordering in _Priority.compareTo()_ and 
> _SchedulerRequestKey.compareTo()_ is inconsistent. Both _compareTo_ method is 
> trying to reverse the order: 
> P0.compareTo(P1) > 0, meaning priority wise P0 < P1. However, 
> SK(P0).comapreTo(SK(P1)) < 0, meaning priority wise SK(P0) > SK(P1). 
> This is attempting to fix that by undo both reversing logic. So that priority 
> wise P0 > P1 and SK(P0) > SK(P1). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to