[ 
https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304075#comment-16304075
 ] 

Panagiotis Garefalakis edited comment on YARN-7682 at 12/26/17 11:43 PM:
-------------------------------------------------------------------------

bq. I think we need to pass the whole SchedulerNode in, not just the nodeId, 
since we need to get node's rack.
Correct

[~asuresh]  [~kkaranasos]  
Following up on the discussion: My only concern is that PlacementConstraints 
util class is part of the API package and TagManager is part of the RM package. 
We would have to move one of them to avoid creating circular maven dependencies.

Thoughts?



was (Author: pgaref):
bq. I think we need to pass the whole SchedulerNode in, not just the nodeId, 
since we need to get node's rack.
Correct

[~asuresh]  [~kkaranasos]  
Following the discussion: My only concern is that PlacementConstraints util 
class is part of the API package and TagManager is part of the RM package. We 
would have to move one of them to avoid creating circular maven dependencies.

Thoughts?


> Expose canAssign method in the PlacementConstraintManager
> ---------------------------------------------------------
>
>                 Key: YARN-7682
>                 URL: https://issues.apache.org/jira/browse/YARN-7682
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Panagiotis Garefalakis
>         Attachments: YARN-7682.wip.patch
>
>
> As per discussion in YARN-7613. Lets expose {{canAssign}} method in the 
> PlacementConstraintManager that takes a sourceTags, applicationId, 
> SchedulerNode and AllocationTagsManager and returns true if constraints are 
> not violated by placing the container on the node.
> I prefer not passing in the SchedulingRequest, since it can have > 1 
> numAllocations. We want this api to be called for single allocations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to