[
https://issues.apache.org/jira/browse/YARN-7613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304182#comment-16304182
]
Arun Suresh commented on YARN-7613:
-----------------------------------
Thanks for updating [~pgaref]
Some comments:
* Lets change the name of {{attemptAllocationOnNode}} in the Algortihm to
{{attemptPlacementOnNode}} - since we already have a similar method on the
Scheduler.
* The cleanTempContainers can become inconsistent if the placement thread pool
size > 1 and if an Appllication sends sends multiple batches. But it might not
be that big a deal, since we are going to request that apps batch all their
schedulingRequest together anyway.
* Add docs to the SchedulingRequestWrapper
* The @Override should be on the line above the method.
> Implement Planning algorithms for rich placement
> ------------------------------------------------
>
> Key: YARN-7613
> URL: https://issues.apache.org/jira/browse/YARN-7613
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Panagiotis Garefalakis
> Attachments: YARN-7613-YARN-6592.001.patch, YARN-7613.wip.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
