[ https://issues.apache.org/jira/browse/YARN-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306550#comment-16306550 ]
Miklos Szegedi commented on YARN-7688: -------------------------------------- Thank you for the patch [~belugabehr]. Please fix the outstanding checkstyle issue. {code} 227 if (!"1".equals(pID)) { 232 if ("1".equals(ppid)) { {code} I actually liked the original order better. {code} 165 LOG.info("ProcessTree: " + p); {code} How about {{LOG.info("ProcessTree: ", p);}}? > Miscellaneous Improvements To ProcfsBasedProcessTree > ---------------------------------------------------- > > Key: YARN-7688 > URL: https://issues.apache.org/jira/browse/YARN-7688 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager > Affects Versions: 3.0.0 > Reporter: BELUGA BEHR > Priority: Minor > Attachments: YARN-7688.1.patch, YARN-7688.2.patch, YARN-7688.3.patch > > > * Use ArrayDeque for performance instead of LinkedList > * Use more Apache Commons routines to replace existing implementations > * Remove superfluous code guards around DEBUG statements > * Remove superfluous annotations in the tests > * Other small improvements -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org