[ 
https://issues.apache.org/jira/browse/YARN-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307683#comment-16307683
 ] 

Arun Suresh commented on YARN-7691:
-----------------------------------

Thanks for the patch [~sampada15]

Can you maybe adjust the indentation to be more consistent with the rest of the 
code.
* The annotations (@Test / @Mock / @SuppressWarning etc.) should be in its own 
line.
* If we are not using the teardown, you can remove it.
* Fix the remaining checkstyle

+1 pending the above.

> Add Unit Tests for Containers Launcher
> --------------------------------------
>
>                 Key: YARN-7691
>                 URL: https://issues.apache.org/jira/browse/YARN-7691
>             Project: Hadoop YARN
>          Issue Type: Task
>    Affects Versions: 2.9.1
>            Reporter: Sampada Dehankar
>            Assignee: Sampada Dehankar
>         Attachments: YARN-7691.001.patch
>
>
> We need to add more test in the recovry path.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to