[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308305#comment-16308305 ]
Arun Suresh commented on YARN-7682: ----------------------------------- Thanks for the update [~pgaref] It is starting to look neat now :) Minor nits: * Looks like changes in PlacementConstratintManager and MemoryPlacementConstratintManager are not needed. * The tests look good - but can you put a brief comment describing the intent of the placementConstratint and expectation especially for the testComplexPlacement case. * In addition to the testProcessor, maybe we can add one more test class -TestPlacementConstraintsUtil, which just tests {{canSatisfyConstraints}} in isolation ? That way, we can add more complex constraint tests in future if needed too. +1 pending the above. [~kkaranasos], thoughts ? > Expose canAssign method in the PlacementConstraintManager > --------------------------------------------------------- > > Key: YARN-7682 > URL: https://issues.apache.org/jira/browse/YARN-7682 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Panagiotis Garefalakis > Attachments: YARN-7682-YARN-6592.001.patch, > YARN-7682-YARN-6592.002.patch, YARN-7682.wip.patch > > > As per discussion in YARN-7613. Lets expose {{canAssign}} method in the > PlacementConstraintManager that takes a sourceTags, applicationId, > SchedulerNode and AllocationTagsManager and returns true if constraints are > not violated by placing the container on the node. > I prefer not passing in the SchedulingRequest, since it can have > 1 > numAllocations. We want this api to be called for single allocations. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org