[ 
https://issues.apache.org/jira/browse/YARN-6486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wilfred Spiegelenburg updated YARN-6486:
----------------------------------------
    Attachment: YARN-6486.005.patch

{quote}For class FairScheduler, I guess you want to deprecate 
nodeLocalityDelayMs and rackLocalityDelayMs instead of nodeLocalityThreshold 
and rackLocalityThreshold. {quote}

Oops, that was a typo sorry about that. The field names look alike.

{quote}For class FairSchedulerConfiguration, I saw you did mention that fields 
like LOCALITY_DELAY_NODE_MS is deprecated in comments, any reason you don't 
annotate them "@Depreated"?{quote}

No nothing specific, the java doc deprecation seemed more important than the 
fields themselves. I just saw that the other fields were marked as deprecated 
without the java doc deprecation. I added the deprecation to the fields also to 
have it in both places.

> FairScheduler: Deprecate continuous scheduling
> ----------------------------------------------
>
>                 Key: YARN-6486
>                 URL: https://issues.apache.org/jira/browse/YARN-6486
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: fairscheduler
>    Affects Versions: 2.9.0
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>         Attachments: YARN-6486.001.patch, YARN-6486.002.patch, 
> YARN-6486.003.patch, YARN-6486.004.patch, YARN-6486.005.patch
>
>
> Mark continuous scheduling as deprecated in 2.9 and remove the code in 3.0. 
> Removing continuous scheduling from the code will be logged as a separate jira



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to